Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Loki to onprem.logging #139

Merged
merged 4 commits into from
May 16, 2020
Merged

Add: Loki to onprem.logging #139

merged 4 commits into from
May 16, 2020

Conversation

nlamirault
Copy link
Contributor

Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com

@nlamirault
Add: Loki to onprem.logging
e3a6255 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@mingrammer
Copy link
Owner

mingrammer commented May 15, 2020 •
edited
Loading

It doesn't seem to have been generated by autogen.sh. Please add a new node with autogen.sh.

Contributing guide: https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

@nlamirault
Update: resize image using convert
ee456bb 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
Fix: typo
b2f35a4 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
Update: use tools autogen
b4792d3 
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
Copy link
Contributor Author

nlamirault commented May 15, 2020 •
edited
Loading

@mingrammer i use autogen.sh and round.
But now i've got some changes into docs/nodes/onprem.md

Any idea ?

python -m unittest tests/*.py -v
test_node_not_in_diagram (tests.test_diagram.ClusterTest) ... ok
test_node_to_node (tests.test_diagram.ClusterTest) ... 
ok
test_node_to_nodes (tests.test_diagram.ClusterTest) ... ok
test_nodes_to_node (tests.test_diagram.ClusterTest) ... ok
test_validate_direction (tests.test_diagram.ClusterTest) ... ok
test_with_global_context (tests.test_diagram.ClusterTest) ... ok
test_with_nested_cluster (tests.test_diagram.ClusterTest) ... ok
test_custom_filename (tests.test_diagram.DiagramTest) ... ok
test_default_filename (tests.test_diagram.DiagramTest) ... ok
test_node_not_in_diagram (tests.test_diagram.DiagramTest) ... ok
test_node_to_node (tests.test_diagram.DiagramTest) ... ok
test_node_to_nodes (tests.test_diagram.DiagramTest) ... ok
test_nodes_to_node (tests.test_diagram.DiagramTest) ... ok
test_validate_direction (tests.test_diagram.DiagramTest) ... ok
test_validate_outformat (tests.test_diagram.DiagramTest) ... ok
test_with_global_context (tests.test_diagram.DiagramTest) ... ok
test_node_to_node (tests.test_diagram.EdgeTest) ... ok
test_node_to_node_with_additional_attributes (tests.test_diagram.EdgeTest) ... ok
test_node_to_node_with_attributes (tests.test_diagram.EdgeTest) ... ok
test_node_to_nodes (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_additional_attributes (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_additional_attributes_directional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_bidirectional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_bothdirectional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_loop (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_onedirectional (tests.test_diagram.EdgeTest) ... ok

----------------------------------------------------------------------
Ran 27 tests in 1.711s

OK

@mingrammer
Copy link
Owner

Don't mind docs change :). It might be due to the unpredictable order of dict keys.

Thank you for contributing!

@mingrammer mingrammer merged commit 6a778fd into mingrammer:master May 16, 2020
@nlamirault
Copy link
Contributor Author

@mingrammer Cool. Thanks for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @mingrammer